Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

body color doesn't work with iFrame embeds #1832

Open
Tracked by #1888
tomasreimers opened this issue Nov 27, 2023 · 0 comments
Open
Tracked by #1888

body color doesn't work with iFrame embeds #1832

tomasreimers opened this issue Nov 27, 2023 · 0 comments
Assignees
@oskarkrawczyk
Labels
3.0 Issue will be completed along or soonafter 3.0 release Bug

Comments

@tomasreimers
Copy link

The ?bodyColor URL parameter for iframe embeds doesn't work. This appears to be because it generates the HTML:

<style>
  #full-embed body {
    background-color: ...
  }
</style>

While the actual shape of the page is of the form:

<body> 
  <div className="full-embed">

  </div>
</body>

So the body selector never matches b/c it's not embedded in #full-embed.

You could fix this by removing the #full-embed from the injected CSS.
@oskarkrawczyk oskarkrawczyk self-assigned this Apr 20, 2024
@oskarkrawczyk oskarkrawczyk added the 3.0 Issue will be completed along or soonafter 3.0 release label Apr 30, 2024
@oskarkrawczyk oskarkrawczyk mentioned this issue Sep 19, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarkrawczyk oskarkrawczyk

Labels
3.0 Issue will be completed along or soonafter 3.0 release Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oskarkrawczyk @tomasreimers