Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modeling): corrected geom2 mirroring transform #1304

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix(modeling): corrected geom2 mirroring transform #1304

merged 1 commit into from
Oct 5, 2023

Conversation

platypii
Copy link
Contributor

@platypii platypii commented Oct 5, 2023

Same as #1302 but for master branch. Fixes #1301

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

@platypii platypii requested a review from z3dev October 5, 2023 09:03
z3dev
z3dev approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@z3dev z3dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@platypii YOU ROCK!

@z3dev z3dev merged commit 8b0306e into jscad:master Oct 5, 2023
2 checks passed
@platypii platypii deleted the transform-mirroring branch October 5, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z3dev z3dev z3dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Union of 2D polygon and its mirrorX doesn't work
2 participants
@platypii @z3dev