X3D serializer: Material RGB colors #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will be glad to address any review comments. |
andreasplesch
commented
Apr 22, 2023
| @@ -177,7 +177,7 @@ const convertAppearance = (object, options) => { | |||
| const colorRGB = object.color.slice(0, 3) | |||
| const diffuseColor = colorRGB.join(' ') | |||
| const emissiveColor = colorRGB.join(' ') | |||
| const transparency = object.color[3] | |||
| const transparency = 1.0 - object.color[3] | |||
There was a problem hiding this comment.
Sorry for the late change. I had never pushed this correction.
z3dev
approved these changes
Apr 22, 2023
There was a problem hiding this comment.
@andreasplesch thanks again for these changes.
its nice to have someone else looking at this code, and making improvements.
|
Thanks, no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
fixes #1231
some additional cleanup as suggested by standardx.