Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSSL::SSL::OP_NO_RENEGOTIATION #212

Open
p-mongo opened this issue Sep 10, 2020 · 2 comments
Open

Add OpenSSL::SSL::OP_NO_RENEGOTIATION #212

p-mongo opened this issue Sep 10, 2020 · 2 comments

Comments

@p-mongo
Copy link

p-mongo commented Sep 10, 2020

This constant is used to disable renegotiation.

MRI:

serene% irb -ropenssl
irb(main):001:0> OpenSSL::SSL::OP_NO_RENEGOTIATION
=> 1073741824

JRuby:

irb(main):001:0> OpenSSL::SSL::OP_NO_RENEGOTIATION
Traceback (most recent call last):
        7: from /home/w/.rbenv/versions/jruby-9.2.11/bin/irb:13:in `<main>'
        6: from org/jruby/RubyKernel.java:1189:in `catch'
        5: from org/jruby/RubyKernel.java:1189:in `catch'
        4: from org/jruby/RubyKernel.java:1442:in `loop'
        3: from org/jruby/RubyKernel.java:1048:in `eval'
        2: from (irb):1:in `evaluate'
        1: from org/jruby/RubyModule.java:3760:in `const_missing'
NameError (uninitialized constant OpenSSL::SSL::OP_NO_RENEGOTIATION)
Did you mean?  OpenSSL::SSL::OP_NO_TICKET

Tested on JRuby 9.2.13.0.

@kares
Copy link
Member

kares commented Oct 5, 2020

Thanks Oleg, not sure it makes sense.
We do not have all OpenSSL constants, some such as controlling renegotiation might not be exposed by Java's SSL.
However, I do not mind keeping this open for future reference, in case we have a more low level backend.

@p-mongo
Copy link
Author

p-mongo commented Oct 5, 2020

If some of the javas expose the respective functionality, exposing this constant in JRuby will allow applications to disable renegotiation in those environments.

If none of the javas expose this functionality, perhaps not having the constant is better, but a note in documentation would be helpful to developers looking for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants