Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include zimg support #190

Open
trapexit opened this issue Aug 16, 2019 · 5 comments · May be fixed by #318
Open

include zimg support #190

trapexit opened this issue Aug 16, 2019 · 5 comments · May be fixed by #318
Labels
first issue Good for newcomers

Comments

@trapexit
Copy link

https://github.com/sekrit-twc/zimg

--enable-libzimg

@plittlefield
Copy link

+1 for this please!

I need the following compiled options...

./configure --enable-gpl --enable-nonfree --enable-libfdk-aac --enable-libx264 --enable-libx265 --enable-libzimg --enable-libmp3lame --enable-libopus --enable-libvorbis --enable-libass --enable-libfontconfig --enable-libfreetype --enable-openssl

... and zimg is the only one missing :-)

How do we add that please?

Regards,

Paully

@jrottenberg jrottenberg added the first issue Good for newcomers label May 3, 2021
@Gleb-ho
Copy link

Gleb-ho commented Sep 6, 2021

+1

@Gleb-ho
Copy link

Gleb-ho commented Sep 6, 2021

I can fork and add this but...
Spent 3 hours, trying to build any image using Dockerfile-s from docker-images folder. What docker version and platform recommended for building images from that repo? Any docs for contributors?

@jrottenberg
Copy link
Owner

What was the error ?

The Dockerfile generated are valid and azure pipeline was able to build all the docker images : https://dev.azure.com/video-tools/ffmpeg/_build/results?buildId=413&view=results

A recent docker, but there's nothing to fancy in the Dockefile, and

docker build -t ffmpeg-local docker-images/${VERSION}/${VARIANT}

For example

docker build    -t   ffmpeg-local-4.4-centos8     docker-images/4.4/centos8

@jrottenberg
Copy link
Owner

See https://github.com/jrottenberg/ffmpeg/blob/master/README.md#contribute for contribution, I'll prepare a dedicate page once I get a chance, it's fair to see it's a bit light at the moment ;-)

jrottenberg pushed a commit that referenced this issue Sep 20, 2021
@jrottenberg jrottenberg linked a pull request Sep 20, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants