-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port copy fix from Node.js core #918
Comments
@manidlou FYI, will be working on pushing a new major release in the coming days with ESM support (refs #746 (comment)); any chance you could tackle this soon? |
It seems not difficult to support esm/cjs at the same time through the build tool, why not do this? esm only can cause other problems. For example, some packages only support cjs, and some packages only support esm. This is very annoying. I can only package all dependencies into the bundle through the build tool. |
@rxliuli We are planning to support both CJS and ESM; due to some special considerations, we can't just use an out of the box solution. See the issue for more details. |
There's a real bug here, but I'm not sure if @bcoe fixed it correctly; see nodejs/node#39372 (comment) |
As per nodejs/node#39372 (comment) Resolves #918
Just opening an issue for nodejs/node#39372 (comment) so this doesn't get forgotten.
The text was updated successfully, but these errors were encountered: