Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boat Icon size - browser differences #929

Open
marc-anemomind opened this issue Oct 29, 2016 · 3 comments
Open

Boat Icon size - browser differences #929

marc-anemomind opened this issue Oct 29, 2016 · 3 comments
Assignees
@marc-anemomind

Comments

@marc-anemomind
Copy link
Collaborator

marc-anemomind commented Oct 29, 2016 •
edited
Loading

In attach file you may see a difference in boat size. From left to right: Firefox, safari, chrome.
capture d ecran 2016-10-29 a 20 21 33

By the way, the right one seems to be the one from firefox.

Sample of the icons proportion attached

mapiconsdemo
@jpilet
Copy link
Owner

jpilet commented Oct 31, 2016

@npagong can you have a look at this issue?
thanks

@npagong
Copy link
Contributor

npagong commented Nov 1, 2016

Okay

@npagong
Copy link
Contributor

npagong commented Nov 1, 2016 •
edited
Loading

The boat icon didn't have sizes set on the VectorTileLayer.js so I set it with 12x34 but the browsers still adjust the SVG's differently. Not just the boat but if you can notice the App-wind and True-wind icons in your screenshots are not also on the same sizes.

Below are the details of the image on Chrome and Firefox.

chrome-img

firefox-img

jpilet added a commit that referenced this issue Nov 3, 2016
@jpilet
Fix boat icon size on map view
8b5bc4a 
should finish addressing #929
@jpilet jpilet mentioned this issue Nov 3, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marc-anemomind marc-anemomind

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpilet @npagong @marc-anemomind