Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMEA parser do not handle empty RMC sentences #1011

Open
jpilet opened this issue Feb 16, 2017 · 1 comment
Open

NMEA parser do not handle empty RMC sentences #1011

jpilet opened this issue Feb 16, 2017 · 1 comment
Assignees

Comments

@jpilet
Copy link
Owner

jpilet commented Feb 16, 2017

Sentences such as

$GNRMC,,V,,,,,,,,,,N*4D
$GNRMC,193355.00,V,,,,,,,020615,,,N*6B

produce wrong data (time and GPS pos):

2015-06-02T19:34:00.159: pos[:0]: (-16, 0)

To search for raw internal GPS nmea in Irene logs, just do:

 for i in *log ; do logcat $i -b | grep -q "Internal GPS NMEA" && echo $i ; done

This is related to #1007, because we must handle old log files that contain the bug properly.
The downSampleGps1Hz function used to filter those bad coordinate out, but its not called anymore.

@jonasseglare
Copy link
Collaborator

I think the parsing functions should produce optionals, so that we can deal with partial NMEA sentences. Having a callback-based system, where a method is called whenever a sentence is parsed would also be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants