Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Check to make sure dimms and cpus are arrays and not objects. #559

Closed
perigrin opened this issue Dec 4, 2018 · 1 comment · Fixed by #573
Closed

Check to make sure dimms and cpus are arrays and not objects. #559

perigrin opened this issue Dec 4, 2018 · 1 comment · Fixed by #573
Labels
device reports Involves data coming from reporters high priority High voltage.

Comments

@perigrin
Copy link
Contributor

perigrin commented Dec 4, 2018

@daleghent pointed out on chat that we're occasionally getting single object values for dimms and cpus when they should be lists.

We currently have nothing that even checks that we're getting a dimms and cpus key in the Device Report. We probably should.
@karenetheridge
Copy link
Contributor

When we parse the device report in lib/Conch/Controller/DeviceReport.pm, nothing extracts that data and moves it to the device_memory table.

This (with the schema update) will need to be fixed before #551.

@karenetheridge karenetheridge added the device reports Involves data coming from reporters label Dec 4, 2018
@sungo sungo added the high priority High voltage. label Dec 4, 2018
karenetheridge added a commit that referenced this issue Dec 6, 2018
@karenetheridge
add json schema entries for all data used by validations
0512acb 
..and cpus, dimms, both of seem to be turning from arrays to hashes on some reporters
closes #559
@karenetheridge karenetheridge mentioned this issue Dec 6, 2018
Merged
karenetheridge added a commit that referenced this issue Dec 10, 2018
@karenetheridge
add json schema entries for all data used by validations
e47dfb3 
..and cpus, dimms, both of seem to be turning from arrays to hashes on some reporters
closes #559
karenetheridge added a commit that referenced this issue Dec 10, 2018
@karenetheridge
add json schema entries for all data used by validations
dc6df9d 
..and cpus, dimms, both of seem to be turning from arrays to hashes on some reporters
closes #559
karenetheridge added a commit that referenced this issue Dec 14, 2018
@karenetheridge
add json schema entries for all data used by validations
d829838 
..and cpus, dimms, both of seem to be turning from arrays to hashes on some reporters
closes #559
karenetheridge added a commit that referenced this issue Dec 14, 2018
@karenetheridge
add json schema entries for all data used by validations
c789ca2 
..and cpus, dimms, both of seem to be turning from arrays to hashes on some reporters
closes #559

(cherry picked from commit d829838)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
device reports Involves data coming from reporters high priority High voltage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add json schema entries for all data used by validations joyent/conch-api
3 participants
@sungo @perigrin @karenetheridge