Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Add device_memory information to DetailedDevice #552

Closed
sungo opened this issue Nov 28, 2018 · 6 comments
Closed

Add device_memory information to DetailedDevice #552

sungo opened this issue Nov 28, 2018 · 6 comments
Labels
api blocked blocked on something else being deployed first enhancement extends current functionality invalid needs-reporter needs accompanying changes in conch-reporter/livesys

Comments

@sungo
Copy link
Contributor

sungo commented Nov 28, 2018

We are extracting information about the memory in a device from the device report into the device_memory table. Near as I can tell, this data is inaccessible from the API. I'd like to see it added to the DetailedDevice response so it is available via GET /device/:serial

@sungo sungo added enhancement extends current functionality api labels Nov 28, 2018
@sungo
Copy link
Contributor Author

sungo commented Nov 28, 2018

See also #551

@karenetheridge karenetheridge self-assigned this Nov 28, 2018
@karenetheridge
Copy link
Contributor

We are extracting information about the memory in a device from the device report into the device_memory table

We're not, actually. At least, I see no code that inserts into that table, and that table is empty in the backup from production from ~September that I'm using. We'll need some specifications around that section of the report so we know how to fetch that data; I'll punt this over to #551.

@karenetheridge karenetheridge added the blocked blocked on something else being deployed first label Nov 28, 2018
@karenetheridge karenetheridge removed their assignment Nov 29, 2018
@sungo
Copy link
Contributor Author

sungo commented Dec 4, 2018

Looking through livesys, specifically https://github.com/joyent/conch-livesys/blob/master/Conch-Reporter/lib/Conch/Reporter/Collect/Memory.pm , I don't think we're even collecting all the data we need to fill the table in the database.

@karenetheridge karenetheridge added the needs-reporter needs accompanying changes in conch-reporter/livesys label Dec 4, 2018
@karenetheridge
Copy link
Contributor

question for reporter folks: do we care about what slot a dimm is in? can/should that just be inferred from the array index?

@sungo
Copy link
Contributor Author

sungo commented Jan 9, 2019

We care about it for reporting purposes. It's important to know exactly which dimm is busted so integrators don't waste time guessing

@sungo
Copy link
Contributor Author

sungo commented Feb 7, 2019

Obsoleted by #650

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api blocked blocked on something else being deployed first enhancement extends current functionality invalid needs-reporter needs accompanying changes in conch-reporter/livesys
Projects
None yet
Development

No branches or pull requests

2 participants