Skip to content
This repository has been archived by the owner on Mar 29, 2019. It is now read-only.

9.11 additional functions clash #31

Open
ibell opened this issue Aug 3, 2015 · 5 comments
Open

9.11 additional functions clash #31

ibell opened this issue Aug 3, 2015 · 5 comments

Comments

@ibell
Copy link
Contributor

ibell commented Aug 3, 2015

In version 9.11 of REFPROP, the additional functions that are included in src/PASS_FTN_ALT.f are no longer needed since they are provided in REFPROP itself. Not sure how best to fix this, but I "fixed" it by commenting out these functions in src/PASS_FTN_ALT.f. Fun times.

@jowr
Copy link
Owner

jowr commented Aug 12, 2015

Shouldn't we just rermove src/PASS_FTN_ALT.f from the sources?

@ibell
Copy link
Contributor Author

ibell commented Aug 13, 2015

Yes that would probably do it, but only if the REFPROP version is >=9.11

On Wed, Aug 12, 2015 at 4:10 AM, Jorrit Wronski notifications@github.com
wrote:

Shouldn't we just rermove src/PASS_FTN_ALT.f from the sources?


Reply to this email directly or view it on GitHub
#31 (comment).

@ghost
Copy link

ghost commented Aug 14, 2015

Excluding it from the compilation process using the makefile would be better, I think, if the file is still distributed with REFPROP 9.11. Doing so, you don't delete it, and you don't need to comment the lines out.

@jowr
Copy link
Owner

jowr commented Aug 14, 2015

Oh, that is what I meant: Remove it from the list of files to compile - not deleting it.

@ghost
Copy link

ghost commented Aug 14, 2015

OK ! :-) ; Does somebody have a REFPROP 9.11 to test the code after the makefile has been modified? It seems that Ian has it. Do you also have a version at hand, Jorrit? Personally, I don't, but I can make the modification and make a pull request, as long as one of you test the code after that :-).

@ghost ghost self-assigned this Aug 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants