Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding provider name property #23

Open
wbobeirne opened this issue Apr 24, 2019 · 0 comments
Open

Consider adding provider name property #23

wbobeirne opened this issue Apr 24, 2019 · 0 comments
Labels
discussion enhancement New feature or request

Comments

@wbobeirne
Copy link
Member

I've seen a few applications are hard-coding the phrase "Joule" around WebLN usage. While I'm flattered to see that, I'd like to avoid a MetaMask / Band-AID / Kleenex situation.

The way Web3 providers in the Ethereum world have traditionally been identified is the all-too-janky way of checking the class's constructor.name. To prevent that from happening here, it might be nice if WebLN providers could optionally provide a providerType or providerName property that identifies it for UI usage. This would allow UIs to do something to the tune of

return (
  <button>Make invoice with {webln.providerName || 'WebLN'}</button>
);

Any concern about fingerprinting or de-anonymizing could be fixed by either omitting the property, or by using the most common provider's name to hide your users (ala Brave avoiding detection by disguising itself as Chrome.)

@wbobeirne wbobeirne added enhancement New feature or request discussion labels Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant