Add Lightning Loop functionality #226
Conversation
|
Whoa, this is awesome. Great start! I'll keep an eye on this as you progress, but my main piece of feedback so far would be to make sure that loop stays an optional addition to Joule. A lot of people won't have loop running, and the eventual support of non-LND nodes means they won't have loop either. Right now the current implementation looks like it alters a lot of method signatures and validation checks to require a functioning loop server. Ideally it would only ask you to configure your loop server when you go to actually use the feature. I'm really looking forward to seeing how this goes! |
|
Thanks @wbobeirne! Good catch! I started to refactor so that the URL for Loop will be set optionally. Still need to add some snackbars so the user knows the URL was set successfully. Will try to finish adding the actual Loop out functionality tomorrow. |
|
Getting close. Was able to attempt initiate a swap but it failed and Joule crashed too (T_T) |
|
|
|
Initiated default loop out from Joule. Will add advanced features for the Loop Out form.
|
reemuru
changed the title
reemuru
changed the title
reemuru
changed the title
|
Added support for Loop In. Will create a separate PR for Loop Monitor. Need loop monitor to support synchronous requests with JSON array value.
|
reemuru
changed the title
|
Yo @wbobeirne check it out and let me know what you think! |
|
Traveling for the next week but excited to see where it's at. Thanks for all of the hard work! |
There was a problem hiding this comment.
This is dope! Unfortunate that loop will require a new release for those RPCs, but I was able to get it working.
Dropped a good bit of feedback, sorry if it's a lot. I'd be happy to pitch in to help get this one out, especially since I'd like to do a good number of tweaks to the form itself.
The last note that I didn't add in code is that we should be saving the loop URL to browser storage. Most people will probably set this up once, and to have to keep re-entering the URL is a little annoying. Let me know if you need some help to point where that gets done.
|
Thanks for the review! Submitted all the recommended changes on one big commit. If you're able to take it from here and work your magic it would be much appreciated. I'm learning a lot! Hope those API changes make it to the next loop release. I will continue learning Go and gRPC so I can work more on loop and lnd. Nice working with you! EDIT: I figured and how to sync the URL for loop so you don't have to keep putting in. That was pretty annoying! |
|
Great work. I'm getting started on a bit of refactoring, will have you review when I'm done. Looking forward to getting this live 🔥 I'll open a new PR for that, so I'm going to close this one for the time being just to make sure no new work or reviews end up on this branch that I have to merge back into the one I'm working on. |
Closes #225
Description
This PR attempts to address inbound liquidity issues by adding support for "Looping Out/In" to an off-chain address. The default address will be the lnd wallet address. The plan is to add a loop-http library similar to the lnd-http lib implementation. Will update as necessary pending changes to the lightning labs loop repo.
LND 0.7.0
Loop 2.2
you will also need to run ./gen_protos.sh in the looprpc directory
update api for loop in lightninglabs/loop#74
Steps to Test
Screenshot