Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location path and tabs #39

Open
bosniamaj opened this issue May 23, 2013 · 0 comments
Open

Location path and tabs #39

bosniamaj opened this issue May 23, 2013 · 0 comments

Comments

@bosniamaj
Copy link

I have tabs with
< a href="#tab1">tab1< /a> and
< a href="#tab2">tab2< /a>
The url location is domain.com/sub/ (which isn't a directory, but rewritten url).
When I click on a tab, "/sub/" is lost and the location in address bar is changed to domain.com/#tab1 instead of domain.com/sub/#tab1 which is a problem if I refresh the page.

When I change
"history.pushState( null, null, window.location.search + $(this).attr('href') );"
to
"history.pushState( null, null, window.location.pathname + $(this).attr('href') );"
in kickstart.js, line 94 - the problem is solved.

I didn't test it to see if this would be a problem for some other things, but it solves it for me right now.

Just wanted you to know of this issue.

Thanks for this awesome tool 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant