You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sendmailer, testmail, sendtest from user controller need to be moved to the newsletter controller.
Some of the actions from the newsletter controller and the actions mentioned above(from user controller) have repeated code, we can merge those actions and make them generalized.
Actions which can be generalized and merged are:
index, opt_in and opt_out
test_opt_in, test_opt_out and testmail(from user controller)
send_opt_out, send_opt_in and sendmailer(from user controller)
send_opt_in_test, send_opt_out_test, sendtest(from user controller)
Also the test and send mail buttons in the top_navbar are confusing, we can move them below individual newsletter beside the edit and delete buttons.
The text was updated successfully, but these errors were encountered:
tejaszambre
changed the title
SMTP From address may not be blank
Code refactoring and removing general test and send mail buttons
Nov 2, 2020
Sendmailer, testmail, sendtest from user controller need to be moved to the newsletter controller.
Some of the actions from the newsletter controller and the actions mentioned above(from user controller) have repeated code, we can merge those actions and make them generalized.
Actions which can be generalized and merged are:
Also the test and send mail buttons in the top_navbar are confusing, we can move them below individual newsletter beside the edit and delete buttons.
The text was updated successfully, but these errors were encountered: