Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoring PR Review Comments as Activity #139

Closed
adityashedge opened this issue Sep 29, 2016 · 2 comments
Closed

Scoring PR Review Comments as Activity #139

adityashedge opened this issue Sep 29, 2016 · 2 comments

Comments

@adityashedge
Copy link

AFAIK PR comments are not considered as Activity in Code Curiosity(correct me if I'm wrong).
It is possible to pull out the Review Comments on pull request using this API.

P.S. The rules for scoring Review Comments should not same as Issue comments because PR comments will be shorter comparatively. So to start off, we can only score those Review Comments which have code blocks.
@nixmaniack
Copy link

I had raised a similar issue at #122. It's now discussed in #91

@adityashedge
Copy link
Author

I would say keep Review Comments as a separate issue where we can discuss the logic.
But you can close this issue as a duplicate of #91, as suggested by @gautamrege in #122
Thank you @nixmaniack for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nixmaniack @adityashedge @rahuljadhav11