-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete import products #17
Open
sbounmy
wants to merge
41
commits into
joshmcarthur:master
Choose a base branch
from
sbounmy:delete_import_products
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pree-1-0 Spree 1 0
Adding Versionfile
product_imports/index
throws an exception
Closed
I'll have to think about this one. Things I like:
Things I'm not sure about:
|
Thanks for your feedback @joshmcarthur ! Sure, take your time and let me know if you have any questions ! |
sbounmy
added a commit
to sbounmy/spree-import-products
that referenced
this pull request
Mar 27, 2012
This was referenced Mar 27, 2012
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Joshua,
Along with #16
I need admin to be able to 'rollback' imports if anything goes wrong so I basically implemented it for my own usage, if you don't feel the usage of this feature, I totally understand :).
This pull request :
This PR is quite long but has model and integration tests aswell, let me know if you have any questions.