Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deface :insert_after should be :insert_bottom for admin tab #9

Open
JupiterJones opened this issue Nov 4, 2011 · 2 comments
Open

Comments

@JupiterJones
Copy link

This may be just for 0.70 (since that's the only Spree I've used) however, :insert_after places the "Import Products" tab outside the admin_tabs div, where it should have been added as a new tab inside that div.

I've changed it in my local copy of the source, but I'm new to github so don't know how to submit it back :)

@joshmcarthur
Copy link
Owner

Submitting is really easy on Github (you've probably heard it mentioned as a pull request :-)). I recommend you check out http://help.github.com/send-pull-requests/ for a quick rundown on how these work.

Basically, if you pop that change you've made into a new branch on your fork, push it back to your repository, and then on GitHub switch to that branch, and hit the 'Pull Request' button - I can then review the changes you've made, and if they are correct, pull them into the main repository.

@joshmcarthur
Copy link
Owner

P.S. - if you reference this issue in your commit - i.e. if your commit message is something like "Deface :insert_after should be :insert_bottom for admin tab - fixes issue #9", then it should show up here when you do the pull request and make it easier for everyone else to trace the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants