Setting background to light and then to dark again changes colors

[Filius-Patris]

• I have carefully read and followed the Installation section of the README
• I have searched through the closed issues to see if there is an existing solution for my issue

Terminal Emulator Info

alacritty, default.

Output From nvim --version

NVIM v0.5.0-dev+1205-g3f7cd18c4

Issue Description

When run the commands set background=light and then set background=dark again, the colors change:

Default:

After setting background to light and then to dark again:

Thank you for this colorscheme!!

[Filius-Patris]

Appendum: I just found out that running colorscheme onedark afterwards reverts everything back to normal again.

Close it if you don't consider it a bug.

[joshdick]

Excerpt from :help background in Neovim 0.4.4:

When a color scheme is loaded (the "g:colors_name" variable is set)
setting 'background' will cause the color scheme to be reloaded.  If
the color scheme adjusts to the value of 'background' this will work.
However, if the color scheme sets 'background' itself the effect may
be undone.  First delete the "g:colors_name" variable when needed.

onedark.vim does include set background=dark as its very last line to work around a different issue, which is seemingly what's causing the behavior you're seeing (if the color scheme sets 'background' itself the effect may be undone.)

I tried removing set background=dark from onedark.vim itself as a test, and this caused Neovim 0.4.4 not to change any colors at all when manually running set background=light and set background=dark repeatedly. Although this is an odd behavior, because it is easily mitigated by just running colorscheme onedark again, I am going to leave the existing set background=dark in place and close this issue.

Thanks for the report!