Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate stash operations if a user clicks multiple times by accident #505

Open
Zanger67 opened this issue Jul 20, 2024 · 2 comments
Labels
i-enhancement New functionality

Comments

@Zanger67
Copy link

Note: Not too important of an issue imo (rarely occurs) but I thought I'd add the issue for the sake of it

System Details

  • OS Version: Windows 10 (10.0.19045 Build 19045)
  • Browser Version: Firefox v128.0 (64-bit)
  • Tab Stash Version: 3.0.1

Installed Browser Extensions:

  • LastPass
    -Momentum
  • Return YT Dislike
  • Video Speed Controller

Describe the Bug

During very high CPU/RAM/both usage occasionally when I begin stashing tabs to prepare to restart my browser to empty caches and whatnot, while TabStash is slowly loading / giving me the chance to click "stash" (on a tab of tabstash), I'll click it but thinking after waiting a bit that it wasn't registered the click I click again but see two separate lines of tabs appear.

The newly added tab groups will be identical but separate (exact same tabs in both groups but separate instances that can be modified, closed, opened, etc. independently).

Steps to Reproduce

  • Overload computer's RAM / CPU with too many tabs from trying to understand TypeScript and Svelte docs (/j)
  • When Firefox is getting slow (namely slow webpage opening, slow tab switching, multi-second delays for a unpause video click to register) open tab stashes instances on each open window
  • Rapid click "stash all and close" on a window that has a significant number of tabs open

Expected Behavior

Single instance of window being stashed

Impact

Additional Details


Readers: If you are also experiencing this bug, please vote for it by giving the ORIGINAL POST a thumbs-up using the 😃 button. You are welcome to leave comments and discuss the issue if you have more details to add, but "Me too!" comments are not counted by the voting system.
@Zanger67 Zanger67 changed the title Stash all during high ram usage causes occasional duplicate stash Stash all during high ram usage causes occasional duplicate and identical stashing Jul 20, 2024
@Zanger67 Zanger67 changed the title Stash all during high ram usage causes occasional duplicate and identical stashing Stash all during high ram and/or CPU usage causes occasional duplicate and identical stashing Jul 20, 2024
@josh-berry
Copy link
Owner

Fair; thanks for letting me know. Generally, stashing should be pretty fast, but there's probably more that can be done to prevent accidental duplicate clicks. I'll keep this in mind!

@josh-berry josh-berry changed the title Stash all during high ram and/or CPU usage causes occasional duplicate and identical stashing Prevent duplicate stash operations if a user clicks multiple times by accident Jul 21, 2024
@Zanger67
Copy link
Author

Ofc! Don't think it's a pressing issue just an observed thing. The lag part is completely my fault for being too lazy to clean tabs up lol I just happened to notice it in the process.

Thanks for the extension it's been a lifesaver for the past year or so. :)

@josh-berry josh-berry added the i-enhancement New functionality label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i-enhancement New functionality
Projects
None yet
Development

No branches or pull requests

2 participants