Replacing old conditional helper

[jose-elias-alvarez]

7427399 removes the conditional helper, previously exposed via require("null-ls.helpers").conditional. It's trivial to replicate its behavior (which is why it was removed):

local sources = {
    -- null-ls allows defining function sources that either return a source or nil
    function()
        local utils = require("null-ls.utils").make_conditional_utils()
        return utils.root_has_file(".eslintrc.js") and b.formatting.eslint_d or b.formatting.prettier
    end,
}

Note that the functionality available via builtin.with({ condition = ... }) has not been removed.
The commit also includes two other non-breaking changes that may affect users:

1. ~Previously, built-in sources with a user-defined `condition` were checked on registration. Now, null-ls will register sources unconditionally and check `condition` when the source first runs. Since this gives us access to editor and project state, this change makes `condition` more useful and shouldn't affect behavior, but it may affect how active sources are reported via `:NullLsInfo` / the `info` API.~ This has been changed and should not result in observable differences in behavior.

2. The `with()` method for built-ins now only allows a subset of options to be configured. All valid options are documented in [BUILTINS](https://github.com/jose-elias-alvarez/null-ls.nvim/blob/main/doc/BUILTINS.md). Note that `helpers.make_builtin` is **only** intended for sources included in the main null-ls repo, and other uses are not explicitly supported. If an option you use is no longer supported and you think it should be, please open an issue.

Previous commit: 2b8967d

Hi!

Before the change this is the way I used to set condition for eslint. Since the conditional helper is removed, is there a recommended way to do this?

require("null-ls.helpers").conditional(function(utils)
    local has_eslint = function(u)
      return utils.root_has_file(".eslintrc")
        or utils.root_has_file(".eslintrc.json")
        or utils.root_has_file(".eslintrc.js")
        or utils.root_has_file("package.json")
        or utils.root_has_file(".eslintrc.cjs")
        or utils.root_has_file(".eslintrc.yaml")
        or utils.root_has_file(".eslintrc.yml")
    end

    formatter.eslint_d.with({
      condition = has_eslint,
    })
    diagnostics.eslint_d.with({
      condition = has_eslint,
    })
    actions.eslint_d.with({
      condition = has_eslint,
    })
  end),

This is my null-ls config if needed. Thank you!

@agentzhao I moved your question to a discussion, since the issue you posted in is intended to provide notifications for breaking changes.

The way you were organizing your setup before doesn't really make a lot of sense, since the idea of the conditional helper was to check a condition and return a single source that met the condition. You can achieve the same results like this:

local has_eslint = function(utils)
    -- root_has_file accepts multiple files now
    return utils.root_has_file({
        ".eslintrc",
        ".eslintrc.json",
        ".eslintrc.js",
        ".eslintrc.cjs",
        ".eslintrc.yaml",
        ".eslintrc.yml",
        "package.json",
    })
end

local sources = {
    formatter.eslint_d.with({
        condition = has_eslint,
    }),
    diagnostics.eslint_d.with({
        condition = has_eslint,
    }),
    actions.eslint_d.with({
        condition = has_eslint,
    }),
}

null_ls.setup({ sources = sources })

[agentzhao]

Sorry, and thank you!