Conditionally register source based on root_dir

[hassec]

With the recent changes to how conditions work, I'd like to ask for the best way to conditionally register a source.
If a condition only gets triggered once the source is run, then in the case of formatting this creates a somewhat odd user experience, IMHO.

To make this more concrete, my case is the following:

root of monorepo:
  .root_identifier_file
  Project A
  Project B
   ...
  Project N

If I open any file inside this monorepo, my LSPs and null-ls to check if .root_identifier_file can be found in parent directories and make that directory the root.

And for null-ls I'd like to have two special conditions if this is the case,

1. use yapf instead of black
2. register clang-format with special path to an older version

But if I'm outside this project I don't want to register clang-format at all.
But if using a condition inside with() then clang-format is registered and the first time I want to format something I'm left with a choice popup between clangd and clang-format.

So what would be the best way to conditionally register sources?
Maybe manually registering them in on_init() ?

[jose-elias-alvarez]

I was thinking about cases like this. I think the right thing to do is to check whether conditional sources should register when first entering a named buffer (not on first run). We'd still have project context and it would solve cases like yours, since the source would never get registered in the first place. I'll see if I can put something together.

[jose-elias-alvarez]

@hassec Could you try #518?

[hassec]

Hi @jose-elias-alvarez thanks so much for the super quick reply! 😊
I've just tried #518, and it seems to fix my problem perfectly! 👍

(sorry for the slower reply, now on vacation until next week. Hope you have a great start into the new year! And thanks again for the super quick reply!!!)