memory leak in router/thrower lead to RabbitMQ unacked timeout #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changed the function to append the message.delivery_tag instead of level as it's universal and unique throughout the session. kept the message id for debugging and if the connection reset somehow and the message.delivery_tag changed. i'm not an expert of RabbitMQ |
|
it seems jasmin does not like delivery_tag very much |
|
Bad change. Nothing works properly. Found a fix. but i will add it in a different pull request. :( |
|
still an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The memory leak is in the thrower router. when dlr level 3 is requested: if level 1 and level 2 are both in the queue, then both have the same message-id. added a function to create a unique id [message-id-level]. when it is not a dlr it will be [message-id-]. Possible same problem in Issue #1142
i don't know enough about managers and no testing setup for it to tinker with manager/dlr. but i suspect the same problem there. @farirat, please check there. 😊👍
Checks