Set name after parent construct #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 8.1 version of Silverstripe 'name' falls back to autogenerated name from 'title'. This results in name 'Focuspoint' instead of 'FocusPoint'. Result is that the db field is not found, causing an error in asset browser. If name is set after the construct call the issue is solved.
|
Hi @RVXD, sorry for the slow reply. I wasn't able to replicate this issue on SS4 (focuspoint 4.0.5) or SS5 (focuspoint 5.0.0) with PHP 8.1. Is this still a problem for you if you update to the latest version of SS4? |
|
p.s. part of the reason for pushing back is that making a change to the master branch won't help you if you are using SS4, as the master branch is targeting SS5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In php8.1 version of Silverstripe Framework 4.12.7 'name' falls back to autogenerated name from 'title'. This results in name 'Focuspoint' instead of 'FocusPoint'. Result is that the db field is not found, causing an error in asset browser. If name is set after the construct call the issue this is solved.