Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle logs created and saved through createLogger in pre-mounted instances #577

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Properly handle logs created and saved through createLogger in pre-mounted instances #577

merged 6 commits into from
Oct 24, 2023

Conversation

jamessimone
Copy link
Collaborator

@jamessimone jamessimone temporarily deployed to Experience Cloud Scratch Org October 23, 2023 19:15 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to Base Scratch Org October 23, 2023 19:15 — with GitHub Actions Inactive
@jongpie jongpie added Type: Bug Something isn't working Logging Source: Lightning Components Items related to using Nebula Logger using JavaScript within lightning components (lwc & aura) Layer: Logger Engine Items related to the core logging engine labels Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...-logger/core/main/logger-engine/classes/Logger.cls 96.38% <ø> (ø)

📢 Thoughts on this report? Let us know!.

jongpie
jongpie approved these changes Oct 24, 2023
View reviewed changes
Copy link
Owner

@jongpie jongpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamessimone thanks again for working on this! Everything looks good to me, I'm going to release this ASAP 🥳

@jongpie jongpie merged commit b140e72 into main Oct 24, 2023
1 check passed
@jongpie jongpie deleted the bugfix/518-create-logger-pending-message-fix branch October 24, 2023 01:28
@jamessimone
Copy link
Collaborator Author

Awesome! So happy to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongpie jongpie jongpie approved these changes

Assignees
No one assigned
Labels
Layer: Logger Engine Items related to the core logging engine Logging Source: Lightning Components Items related to using Nebula Logger using JavaScript within lightning components (lwc & aura) Type: Bug Something isn't working
Projects
None yet
Milestone
Version 4.12.0: Winter '24 Release
Development

Successfully merging this pull request may close these issues.

LWC - Logs not created for some lifecycle events when using new createLogger() pattern
2 participants
@jamessimone @jongpie