Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic field visibility for LogEntry__c HTTP response header fields #569

Merged

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Oct 12, 2023

New LogEntry__c checkbox fields

  • Added new checkbox fields on LogEntry__c for each long textarea fields that didn't previously have an equivalent checkbox field. Note: these new fields will be inaccurate for existing LogEntry__c records (but correct on new records).
    • HasDatabaseResultJson__c - set based on logEntry.DatabaseResultJson__c != null
    • HasHttpRequestBody__c - set based on logEntry.HttpRequestBody__c != null
    • HasHttpResponseBody__c - set based on logEntry.HttpResponseBody__c != null
    • HasHttpResponseHeaderKeys__c - set based on logEntry.HttpResponseHeaderKeys__c != null
    • HasHttpResponseHeaders__c - set based on logEntry.HttpResponseHeaders__c != null
  • Code cleanup: rewrote several existing tests in LogEntryHandler_Tests to be true unit tests that do not rely on DML

Dynamic field visibility for LogEntry__c HTTP response header field

…t didn't previously have an equivalent checkbox field

Also rewrote several tests in LogEntryHandler_Tests to be unit tests without DML
…ional visibility for the fields HttpResponseHeaderKeys__c and HttpResponseHeaders__c, based on the new checkbox field HasHttpResponseHeaders__c
@jongpie jongpie added Type: Enhancement New feature or request Salesforce Feature: Reporting Anything related to reports, dashboards, and the underlying data model Layer: Log Management Items related to the custom objects & Logger Console app labels Oct 12, 2023
@jongpie jongpie temporarily deployed to Base Scratch Org October 12, 2023 02:13 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org October 12, 2023 02:13 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org October 12, 2023 02:23 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org October 12, 2023 02:36 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the feature/dynamic-field-visibility-for-http-response-headers branch from 858180f to bb3b92b Compare October 12, 2023 20:28
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org October 12, 2023 20:34 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org October 12, 2023 20:34 — with GitHub Actions Inactive
@jongpie jongpie marked this pull request as ready for review October 12, 2023 20:37
@jongpie jongpie temporarily deployed to Demo Org October 12, 2023 20:43 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...re/main/log-management/classes/LogEntryHandler.cls 93.03% <100.00%> (+0.17%) ⬆️
...-logger/core/main/logger-engine/classes/Logger.cls 96.38% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@jongpie jongpie merged commit f2fe85c into main Oct 13, 2023
@jongpie jongpie deleted the feature/dynamic-field-visibility-for-http-response-headers branch October 13, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: Log Management Items related to the custom objects & Logger Console app Salesforce Feature: Reporting Anything related to reports, dashboards, and the underlying data model Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show either HTTP Response Header Keys or HTTP Response Headers, not both, on Log Entries
2 participants