Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for unhandled exception when email limits are reached #548

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Bugfix for unhandled exception when email limits are reached #548

merged 3 commits into from
Sep 19, 2023

Conversation

patrick-skamarak
Copy link
Contributor

Fixes #547

@patrick-skamarak patrick-skamarak changed the title add catch for System.HandledException bugfix/unhandled-exception-when-email-limits-are-reached Sep 15, 2023
@jongpie jongpie added Type: Bug Something isn't working Layer: Log Management Items related to the custom objects & Logger Console app labels Sep 19, 2023
@jongpie
Copy link
Owner

jongpie commented Sep 19, 2023

@patrick-skamarak thanks for reporting this issue & submitting a PR for it! I think your changes look good to me - I'll work on getting this PR merged & released this week.

There is also a related open issue, #369. Long-term, I think completing some of the changes mentioned in #369 should prevent (or drastically reduce) the usage of the SingleEmail limits. I'll look into that issue again to see if I can get it implemented in the coming weeks.

@jongpie
Added test method in LoggerEmailSender_Tests to validate that it prop…
4f18492 
…erly handles when the org's single email limit has been exceeded
@jongpie jongpie changed the title bugfix/unhandled-exception-when-email-limits-are-reached Bugfix for unhandled exception when email limits are reached Sep 19, 2023
@jongpie jongpie merged commit 41e6594 into jongpie:main Sep 19, 2023
6 of 7 checks passed
@jongpie jongpie added Feature: Tags Items related to Nebula Logger's tagging/labeling functionality Layer: Logger Engine Items related to the core logging engine Feature: Email Notifications and removed Layer: Logger Engine Items related to the core logging engine labels Oct 4, 2023
@jongpie
Copy link
Owner

jongpie commented Oct 15, 2023

@patrick-skamarak just wanted to keep you updated - the related issue #369 has been fixed in the latest release, v4.11.11 🥳

@patrick-skamarak
Copy link
Contributor Author

@patrick-skamarak just wanted to keep you updated - the related issue #369 has been fixed in the latest release, v4.11.11 🥳

awesome! thanks for the heads up @jongpie

@patrick-skamarak patrick-skamarak deleted the bugfix/unhandled-exception-when-email-limits-are-reached branch October 17, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongpie jongpie Awaiting requested review from jongpie jongpie is a code owner

Assignees
No one assigned
Labels
Feature: Email Notifications Feature: Tags Items related to Nebula Logger's tagging/labeling functionality Layer: Log Management Items related to the custom objects & Logger Console app Type: Bug Something isn't working
Projects
None yet
Milestone
Version 4.12.0: Winter '24 Release
Development

Successfully merging this pull request may close these issues.

Unhandled exception when email limits are reached
2 participants
@patrick-skamarak @jongpie