Skip to content
This repository has been archived by the owner on Sep 1, 2021. It is now read-only.

sgui in sisl #1

Open
zerothi opened this issue May 27, 2020 · 3 comments
Open

sgui in sisl #1

zerothi opened this issue May 27, 2020 · 3 comments

Comments

@zerothi
Copy link

zerothi commented May 27, 2020

Hi Jonas,

Your sgui command is a nice addition.
I have thought about this and would like it to be in sisl.

I have some things to finish first but we can have the discussion here.

My idea is a command like the following:

sgui <mode> <flags for mode>
sgui <flags for default mode>

I think that your ASE gui should be the default since it is mostly applicable.

Pol has made some gui stuff, one using plotly and one using blender.
So essentially one should be able to do:

sgui ase geom.xyz
sgui geom.xyz # default to sgui ase geom.xyz
sgui blender geom.xyz
sgui plotly geom.xyz

how do you feel about this?
Or do you think it would be better to have sgui-ase, sgui-blender? We could support both?

@jonaslb
Copy link
Owner

jonaslb commented May 27, 2020

Hi Nick,

It sounds like a good idea :)
I haven't tried Pol's blender thing, but it sounds like a pretty good idea as well.

I'd prefer to have it be a single sgui command, that way you don't "litter" your path with some things which you may not have installed. Eg. if there was a 'vmd' backend, there'd also be a sgui-vmd command, but if you actually don't even have vmd installed, it might be weird to have that.

If it is about autocompletion, maybe using something like argcomplete could help out.

Did you consider adding it as an action on sgeom? Eg if it could do sgeom input.fdf -tx 2 -gui [ase|blender|...], that'd be pretty cool as well. Maybe a similar option could be made for sdata and grid visualization.

@zerothi
Copy link
Author

zerothi commented May 27, 2020

I'd prefer to have it be a single sgui command, that way you don't "litter" your path with some things which you may not have installed. Eg. if there was a 'vmd' backend, there'd also be a sgui-vmd command, but if you actually don't even have vmd installed, it might be weird to have that.

Yeah, probably just stick with one.

If it is about autocompletion, maybe using something like argcomplete could help out.

Yeah, this would also be nice. :)
One more thing to do...

Did you consider adding it as an action on sgeom? Eg if it could do sgeom input.fdf -tx 2 -gui [ase|blender|...], that'd be pretty cool as well. Maybe a similar option could be made for sdata and
grid visualization.

Hmm, lets see, this could be cool, but I don't know how this wouldn't complicate things too much? Lets see. :)

@zerothi
Copy link
Author

zerothi commented May 27, 2020

I'll work a bit more on the blender stuff from Pol, then I ping you once I get to it. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants