Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor entire draw instruction subsystem #32

Open
jon-axon opened this issue Mar 29, 2023 · 0 comments
Open

Refactor entire draw instruction subsystem #32

jon-axon opened this issue Mar 29, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jon-axon
Copy link
Owner

While adding SUPER-CHIP high-resolution support, the codebase relating to execution of DXYN instructions and associated manipulation of the bitmapped frame buffer became very ugly and unwieldy; this can and should be greatly simplified. This should ideally rationalise all the following methods (plus any helpers):

Processor::execute_DXYN()
Processor::execute_DXYN_chip8()
Processor::execute_DXYN_superchip11_low_res()
Processor::execute_DXY0_superchip11()
Processor::execute_DXY0_superchip11_low_res()
Display::draw_sprite()

As part of this, associated unit tests should be re-worked and extended, as coverage here is also weaker than in other places in the codebase.

@jon-axon jon-axon added the enhancement New feature or request label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant