Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize checkboxes and colors light and dark #789

Open
editwentyone opened this issue Jul 1, 2024 · 11 comments
Open

optimize checkboxes and colors light and dark #789

editwentyone opened this issue Jul 1, 2024 · 11 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@editwentyone
Copy link

editwentyone commented Jul 1, 2024

it would be nice to update the checkbox with the checkmark inside, and also update the component to reflect the correct color, in light and dark mode

3 states checked, unchecked, deactivated for

  • green / cjoined
  • blue / frozen
  • red / reused etc
  • black / fidelity bond and default

https://www.figma.com/design/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?node-id=7227-18475&t=eVs79CY4QY32REZM-11

image
@editwentyone editwentyone added the bug Something isn't working label Jul 1, 2024
@theborakompanioni theborakompanioni added the good first issue Good for newcomers label Sep 12, 2024
@MarnixCroes MarnixCroes removed the bug Something isn't working label Sep 13, 2024
@Shash-Projects
Copy link

Hi, i was just checking out some issues and wanted to contribute to the repo. I see this issue has been up for months now. Can i be assigned this issue ?

@editwentyone
Copy link
Author

@Shash-Projects of course :) here you go and have fun. thank you

@khadar1020
Copy link

Hi can I contribute to this issue if no one is working on it?

@MarnixCroes
Copy link
Contributor

Hi can I contribute to this issue if no one is working on it?

Of course

@theborakompanioni
Copy link
Collaborator

ping @khadar1020 @Shash-Projects Please coordinate! Maybe you can work together? Just try to avoid doubling the effort! : -)

@Shash-Projects
Copy link

My jm_regtest_bitcoind is neither runnging nor i have any idea how to create this container. Please help

@theborakompanioni
Copy link
Collaborator

My jm_regtest_bitcoind is neither runnging nor i have any idea how to create this container. Please help

Hey @Shash-Projects, please excuse the late reply.
What or where do you have problems when following https://github.com/joinmarket-webui/jam/blob/devel/docker/regtest/readme.md?

@tinkerer-shubh
Copy link

tinkerer-shubh commented Jan 20, 2025

@theborakompanioni Hi, I am also having problems with setting up the project locally. The process is stuck at the second step:

start the regtest environment

npm run regtest:up

Maybe I am missing something obvious here, but I would really appreciate the help regarding this.

Image

The above thing is what I keep seeing in my terminal and it's stuck there.

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Jan 20, 2025

@theborakompanioni Hi, I am also having problems with setting up the project locally. The process is stuck at the second step:

npm run regtest:up

Maybe I am missing something obvious here, but I would really appreciate the help regarding this.

The above thing is what I keep seeing in my terminal and it's stuck there.

Hey @tinkerer-shubh! As far as I can see - this is intended behaviour. npm run regtest:up runs the docker setup and attaches to it. You can either run additional commands in another console tab, or run npm run regtest:up -- --detach to run it in the background. If you can login after running npm run dev, everything is set up correctly.
Let me know if you encounter any other hurdles.

@tinkerer-shubh
Copy link

tinkerer-shubh commented Jan 21, 2025

Hi @theborakompanioni,

Thank you so much for your help! The commands npm run regtest:up and npm run regtest:init worked perfectly without any issues. However, I'm running into a problem with npm run dev.

While the command opens the browser window as expected, there’s no activity in the console or the network tabs, and nothing is being served on port 3000. I’ve confirmed that the port isn’t being used by any other process.

Could I be missing a step or configuration?

Thanks again for your guidance!

Image

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Jan 21, 2025

Thank you so much for your help! The commands npm run regtest:up and npm run regtest:init worked perfectly without any issues. However, I'm running into a problem with npm run dev.

While the command opens the browser window as expected, there’s no activity in the console or the network tabs, and nothing is being served on port 3000. I’ve confirmed that the port isn’t being used by any other process.

Could I be missing a step or configuration?

If you run it for the first time, it takes a while and displays Starting the development server... for several seconds. After that, it should display something like

Compiled successfully!

You can now view jam in the browser.

  Local:            http://localhost:3000
  On Your Network:  http://192.168.1.1:3000

Note that the development build is not optimized.
To create a production build, use npm run build.

webpack compiled successfully
No issues found.

Does it still not load after several minutes? What does the console say after you run npm run dev? Make sure you use the development branch (git checkout devel).

What version of npm and node do you run locally?
Your setup needs to meet these minimum requirements:

> npm --version
10.9.0
> node --version
v22.11.0

Hope this helps.

If nothing works, please post the output of npm run build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants