Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ui) Implement UTXO Selection Modal #765

Closed
amitx13 opened this issue May 28, 2024 · 11 comments · Fixed by #771
Closed

(ui) Implement UTXO Selection Modal #765

amitx13 opened this issue May 28, 2024 · 11 comments · Fixed by #771
Assignees
Labels
enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience
Milestone

Comments

@amitx13
Copy link
Contributor

amitx13 commented May 28, 2024

subtask of #689
Aim : (ui) Quick freeze/unfreeze UTXOs from selected source Jar

Description: Users should have the ability to select specific UTXOs when performing a direct-send or participating in a coin-join. This functionality aims to give users greater control over their UTXOs. We will implement a modal that allows users to select specific UTXOs. This modal should open when the user clicks on the source jar, similar to the interface in /wallet within the Jam application.
Screenshot from 2024-05-28 10-06-46

Objective:
Provide a quick and simple way for users to freeze or unfreeze UTXOs. Note that this is not full coin control but a simplified version to meet user needs for basic UTXO management.

@amitx13 amitx13 added enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience labels May 28, 2024
@amitx13 amitx13 added this to the SoB milestone May 28, 2024
@amitx13 amitx13 self-assigned this May 28, 2024
@amitx13 amitx13 changed the title Implement UTXO Selection Modal (ui) Implement UTXO Selection Modal May 28, 2024
@amitx13
Copy link
Contributor Author

amitx13 commented May 28, 2024

@editwentyone What do you think? Should I use the same modal, or is there something else in your mind to make the UI flow more intuitive and user-friendly?

@editwentyone
Copy link

@amitx13 what do you think about this?

behavior: the lower area should be closed when loading the modal, default all green utxos are preselected, the user can now deselect some when needed. the blue area is just for the complete picture

https://www.figma.com/design/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?node-id=6913-17541&t=CTiV3pSEDEFVU3ba-11

image

@editwentyone
Copy link

when selecting the jar we can hint coin control by opening up the Jar and the user can click the jar to start the modal
https://www.figma.com/design/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?node-id=5276-74107&t=CTiV3pSEDEFVU3ba-11

image

@amitx13
Copy link
Contributor Author

amitx13 commented May 30, 2024

Wow, the UI flow looks way cooler now. Thanks for the suggestions, @editwentyone

@amitx13
Copy link
Contributor Author

amitx13 commented Jun 2, 2024

Hey , @editwentyone and @theborakompanioni I am done with the flow and also added some checks to give user a bigger picture
1. If none of the UTXO's are selected and user tries to proceed
Screenshot from 2024-06-02 11-52-34

2. If the user tries to Unfreeze UTXO, which is used to create a Fidelity Bond
image

3. In case all the UTXO's are frozen in a jar
Screenshot from 2024-06-02 11-52-59

@editwentyone
Copy link

editwentyone commented Jun 3, 2024

case 2 and 3 are solid! good thinking. just add some margin left and right to the whole container, its a little to close to the border

for case 1: instead of a "warning" in red, we could just disable the next button until the user selects minimum one valid UTXO. if that's not enough then lets keep the message but in yellow as a warning (yellow) or info (grey), not an error (red) + and the disabled button mechanic

what do you think? awesome work so far

@amitx13
Copy link
Contributor Author

amitx13 commented Jun 3, 2024

Thanks for the feedback! Yeah, it's a warning, so going with yellow and disabling the next button is a pretty good idea, tho. Thanks!

@editwentyone
Copy link

2 other notes:

  • the checkboxes are not square and looks "different"? hard to understand if they are selected or not (dark mode tested, easier in light mode)
  • if there are no frozen utxos, we don't need the collapse line
  • more padding on div.modal-body: from 16 up to ~40?

@theborakompanioni
Copy link
Collaborator

Just for my understanding.. the goal is "Quick freeze/unfreeze UTXOs from selected source Jar", it is? It feels this comes across like a real "Coin Control" feature, which it is not, right?

@editwentyone
Copy link

editwentyone commented Jun 4, 2024

also you are right, its opening immediately when source is selected. the Figma example above shows how the jar should change after selection to preview that there is a function hidden (by clicking the jar) to bring up the modal

flow:

  • first user selects the source (radio button)
  • when A is selected than the JAR changes to an open state with "select UTXOs" tooltip again and stays like this
  • the user can't look into other jars when not preselected by radio
  • so the modal is just for the preselected JAR (example here is A)
  • if user selects another jar B, that opens up with "select UTXOs" tooltip above and A closes again

@editwentyone
Copy link

editwentyone commented Jun 4, 2024

update with new wording to emphasize its not coin control (open to other text suggestions), also please consider the labeling of both buttons at the bottom

https://www.figma.com/design/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?node-id=6913-17541&t=CnX9tjp55Ds1Y2VB-11

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants