Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ad_format Torpids results have different division sizes than Anu's bumps charts #16

Open
mcshane-fire opened this issue Aug 17, 2023 · 3 comments

Comments

@mcshane-fire
Copy link
Collaborator

A few examples are 1880, 1882, 1884, 1888.

Example with 1880, in results/ad_format/t1880m.txt there are 12 crews in the first division, but in https://eodg.atm.ox.ac.uk/user/dudhia/rowing/bumps/t1880/ there are 11. I think the bumps chart is correct, looking at how Worcester and Oriel go up to the first division by bumping to the top of division 2 then as the sandwich crew.

Can you have a look at this and see how this error crept in? We can manually compare all the results but if there is an automatic way to detect & fix these errors that would be great.

@johnwalley
Copy link
Owner

johnwalley commented Aug 17, 2023

I've checked 1880, 1882, 1884 and 1888 and they all match the available results files from Anu. I agree that the divisions in the charts look correct.

Another manual job I fear. And for years without crews bumping up twice to go up a division there might not be a way to tell at all?

@johnwalley
Copy link
Owner

The notes for 1880 are suggestive

Original charts in Sherwood do not show the boundary between divisions, but this can be located by the Sandwich boat bumps on Saturday and Tuesday.

@johnwalley
Copy link
Owner

This is an example of an original chart from Sherwood and none, up until at least 1900, come with division boundaries.

Screenshot 2023-08-17 at 23 16 41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants