Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle cancelled divisions #11

Open
mcshane-fire opened this issue Jul 28, 2023 · 3 comments
Open

How to handle cancelled divisions #11

mcshane-fire opened this issue Jul 28, 2023 · 3 comments

Comments

@mcshane-fire
Copy link
Collaborator

In 2023 Lents some of the divisions were cancelled, with the result that some divisions completed their first three races, other their first two, and other the first two and the last race.

My format already had support for a 't' code which means terminate that division. It didn't quite handle the lents 2023 scenario, but I've changed my parsing code so that results that follow a 't' go to the correct place. With a little tinkering to show light grey line if there a split between results, this shows what I render from the results file.

lents2023_women

lents2023_women.txt

Is this a good suggestion of how these types of events should be handled?

@johnwalley
Copy link
Owner

Oh, that looks like a nice way to handle it.

I'm a bit rusty on the meaning of t. Does the following describe the new situation?

  1. t by itself -> division cancelled
  2. Normal results followed by t -> remaining crews rowed over

@mcshane-fire
Copy link
Collaborator Author

I think originally t meant number 2 on your list, and possibly number 1. I'm thinking that number 2 is just a bit lazy and not very useful (and potentially confusing), so I'm suggesting it's only allowed as option 1 (so it must be the first result for a new division).

@mcshane-fire
Copy link
Collaborator Author

mcshane-fire commented Aug 11, 2023

Having said that, the parsing code I checked in https://github.com/mcshane-fire/bumps/blob/master/src/bumps.py allows for both of your suggestions.

  1. If none of the crews in that division have a results code and we see a 't' then that division is shown as not racing.
  2. If there has been at least one other result code for that division before the 't' then I assume the whole division raced (with crews yet to have results rowing over).

In the results files that I'm generating I don't rely on that second use case, but the description of this result code in https://github.com/mcshane-fire/bumps/blob/master/readme.txt does implicitly allow both use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants