Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of variable names #618

Open
a-dekker opened this issue Jan 4, 2025 · 1 comment
Open

Inconsistent use of variable names #618

a-dekker opened this issue Jan 4, 2025 · 1 comment

Comments

@a-dekker
Copy link

a-dekker commented Jan 4, 2025

Running the Alpha branch for a while now, no big issues. One thing I did notice is that some json keys changed their name which broke some tools I run based on the output.
pvfrequentie is now called pvfrequency. It is indeed better to use English terms instead of Dutch given the audience. But the pvfrequentie name is still used all over the place.
Another issue I encountered is the pvipmtemperature key. A lot of times it is referred to as the incorrect pvimptemperature key in the code.

A simple search/replace in the codebase should fix this.

@johanmeijer
Copy link
Owner

Thanks. I will change it. Luckely, for compatibility reasons, we can define multiple Keys pointing to the same register content.

Sometimes it is difficult for a dyslexic like me to be consistent with naming. Sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants