Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in generated_pv_energy_today #223

Open
RienduPre opened this issue Nov 5, 2022 · 4 comments
Open

Bug in generated_pv_energy_today #223

RienduPre opened this issue Nov 5, 2022 · 4 comments

Comments

@RienduPre
Copy link

"value_template": "{{value_json.epvToday| float / 10 }}",

value_json.epvTodaycontains a capital (T) and must be lowercase (t)

@egguy
Copy link
Contributor

egguy commented Nov 7, 2022

Hi, thanks for the bug report.

It seems I was confused by the SPH inverter, which has an epvToday field while the others are epvtoday.

I will try to correct it soon in the -current version of the HA addon.

egguy added a commit to egguy/grott that referenced this issue Nov 7, 2022
egguy added a commit to egguy/grott that referenced this issue Nov 7, 2022
@johanmeijer
Copy link
Owner

johanmeijer commented Nov 8, 2022

Oké. We can fix this but this can cause an incompatibility for people already using this in their mqtt processing or influxdb.

The solution would be not to change it, but add a second key I think (other name same offset). They can then be used next to it each other.

Backwards compatibility is always a thing to keep in mind ;)

@RienduPre
Copy link
Author

WhT’s the status on this?

@egguy
Copy link
Contributor

egguy commented Feb 15, 2023

Hello,
There's now an auto generation of the correct template, this prevents case problem, the epvtoday in the current version is using this function and address this problem.
ex: https://github.com/egguy/grott/blob/feature/ha-extension/examples/Home%20Assistent/grott_ha.py#L167

brikcoda pushed a commit to brikcoda/growitool that referenced this issue Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants