-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] All tests fail #32
Comments
Which compiler and which version of that compiler do you have? |
|
Any local patches? I see |
This is using the code modifications proposed at #31. |
Remove the |
The build fails without the patch, because the codebase uses some relatively recent C++ extensions, but it seems that on macOS the default compiler standard predates
I tried C++14 and all tests still fail. I tried C++17, and the plugin failed to build (Problem with third-party libtorrent-rasterbar: |
Do you see anything if you run one of the tests in gdb, or using valgrind? If I read the logs correctly, the test process got stuck and was killed by the test suite. If so, can you figure out where it is hanging? |
Valgrind isn't supported yet on Mojave: https://bugs.kde.org/show_bug.cgi?id=399584. I'm familiar with |
I couldn't make this build either. See comment #50 (comment) for an alternative (albeit very different-) solution to getting Torrent-to-VLC direct streaming working in macOS. |
Using information at https://github.com/nurupo/vlc-pause-click-plugin/blob/master/BUILD.md, I was able to get
vlc-bittorrent
to compile without error on macOS Mojave. Yay! However, I cannot get the plugin to do anything, and when I trymake check
, all tests fail:Here's the log file in case it's useful:
test-suite.log
Thoughts?
The text was updated successfully, but these errors were encountered: