Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect "show bundle" setting for bundles #1

Open
Ajedi32 opened this issue Jul 18, 2015 · 4 comments
Open

Respect "show bundle" setting for bundles #1

Ajedi32 opened this issue Jul 18, 2015 · 4 comments

Comments

@Ajedi32
Copy link

Ajedi32 commented Jul 18, 2015

Inbox provides a feature that lets you hide bundles from the inbox and only show them once every day or week. (So you can deal with all the emails in the bundle at once, instead of dealing with them individually as they come in.)

This extension should respect that setting, and not include those emails in the count shown on the Inbox icon until they are displayed in the inbox.

@Ajedi32
Copy link
Author

Ajedi32 commented Jul 18, 2015

Looks like this would be pretty difficult, as it seems this extension is currently getting the unread count from Gmail, not Inbox.

@joeyespo
Copy link
Owner

Yeah, this would be hard with the way it's set up. I think you'd have to have an official "Sign in with Google" to get access to the right API. (Please correct me if I'm wrong.)

Thanks for the issue. It's definitely worth adding if there's a good way to do it.

@joeyespo
Copy link
Owner

joeyespo commented Feb 6, 2016

This issues seems to come up a lot in the reviews.

Anyone have any ideas on how to fix this without requiring an additional login?

@Ajedi32
Copy link
Author

Ajedi32 commented Feb 6, 2016

Well, the extension already has permission to read from inbox.google.com directly. So maybe that would be enough?

Anyway, I think most extensions like this that I've seen don't require a separate login, just an oauth token. (The user has to click through a permissions prompt from Google before the extension will work properly.) What API were you planning to use?

joeyespo added a commit that referenced this issue Feb 20, 2016
After using an old computer for the first time in a while, I noticed it was having the connectivity problem.
So I checked the extension's console and saw that the response from mail.google.com was
"Failed to load resource: the server responded with a status of 401 (OK)"

After manually visiting mail.google.com, the problem went away. This mimic the workaround I tried.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants