Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withoutOverlapping will actually run command every 24 hours #116

Open
jankulma opened this issue Jul 17, 2018 · 1 comment
Open

withoutOverlapping will actually run command every 24 hours #116

jankulma opened this issue Jul 17, 2018 · 1 comment

Comments

@jankulma
Copy link

Hello,

In https://github.com/joeldg/bowhead/blob/master/app/Console/Kernel.php#L47 you use withoutOverlapping which should prevent executing a command if it is already running. But if you see this method, you'll notice that there is an argument with default value 1440 which stands for 24h. So basically the command will be run again every 24 hours, despite if it is already running or not.

Some more details: laravel/framework#18202

I'm not sure if this is actually an issue for you. I build my own app loosely inspired by yours, and I encountered this, so I wanted to share it.

Thanks,
Jan

PS I posted this twice, please delete #115

@joeldg
Copy link
Owner

joeldg commented Jul 24, 2018

thanks, will look into it.. been swamped lately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants