Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in goapidiff showing new changes as breaking #65

Open
wtrocki opened this issue Sep 2, 2024 · 1 comment
Open

Regression in goapidiff showing new changes as breaking #65

wtrocki opened this issue Sep 2, 2024 · 1 comment

Comments

@wtrocki
Copy link
Contributor

wtrocki commented Sep 2, 2024 •
edited
Loading

Example:

▶ $GOPATH/bin/go-apidiff  "$GIT_BASE_REF" --compare-imports="false" --print-compatible="true"

  Incompatible changes:
  - Api.CreateSearchDeployment2: added

Go version: go 1.21
@wtrocki wtrocki closed this as completed Sep 4, 2024
@wtrocki wtrocki reopened this Sep 16, 2024
@joelanford
Copy link
Owner

Interesting! Are you able to provide a working reproducer? Also when you say regression, do you mean that there is a previous version of go-apidiff that does not report the same change as breaking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joelanford @wtrocki