allowNull
flag for CompareValidator
#476
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Close #473
Solution description
Allow
null
values forCompareValidator
.Use case example: a shopping application. User can specify price range to search for matching products. If either
min
ormax
prices are null, that's fine - this side of the search filter won't be limited. But if both are specified, a validation is needed (expected:min <= max
).Possible workarounds for this functionality are verbose:
CompareValidator
should be duplicated as a custom validator (allowing nulls)composeOR
can be used in combination with a customAllowNullValidator
(reports VALID if value is null thus suppressingCompareValidator
report)Due to the verbosity of workaround solutions, it would be more convenient to have this option implemented in the library 🙏
Also, please see PR #451 with a similar approach applied to
NumberValidator
.To Do