Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReactiveDropdownField to use newer DropdownMenu #462

Open
cappyccino opened this issue Aug 26, 2024 · 3 comments
Open

Update ReactiveDropdownField to use newer DropdownMenu #462

cappyccino opened this issue Aug 26, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@cappyccino
Copy link

Environment

Package version: 17.0.1 / latest

Description

What you'd like to happen:

Flutter released an updated version of DropdownButton, called DropdownMenu. Its API is slightly different, but it simplifies the logic and fixes some styling issues like multiline dropdown items. There's a basic migration guide on the DropdownButton docs.

It would be great to update the ReactiveDropdownField to use the new widget under the hood, or at least allow for the option to use it.

@cappyccino cappyccino added the enhancement New feature or request label Aug 26, 2024
@cappyccino cappyccino changed the title Update ReactiveDropdownField to use newer DropdownMenu instead of DropdownButton Update ReactiveDropdownField to use newer DropdownMenu Aug 26, 2024
@vasilich6107
Copy link
Contributor

vasilich6107 commented Aug 28, 2024

@cappyccino

Not sure if updating ReactiveDropdownField if possible cause it will introduce breaking change which will affect lot's of users.

check https://pub.dev/packages/reactive_dropdown_menu

@hammonjj
Copy link

hammonjj commented Sep 4, 2024

@vasilich6107 Couldn't this just be part of another version which requires an upgrade from other users? Breaking changes between library versions aren't uncommon

@vasilich6107
Copy link
Contributor

There is almost zero reasons to include the actual controls into the form engine bundle.
It just makes things harder to maintain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants
@hammonjj @cappyccino @vasilich6107 and others