diff --git a/k4FWCore/include/k4FWCore/MetaDataHandle.h b/k4FWCore/include/k4FWCore/MetaDataHandle.h index c923b785..0a906428 100644 --- a/k4FWCore/include/k4FWCore/MetaDataHandle.h +++ b/k4FWCore/include/k4FWCore/MetaDataHandle.h @@ -26,7 +26,6 @@ template class MetaDataHandle { public: - MetaDataHandle(); MetaDataHandle(const std::string& descriptor, Gaudi::DataHandle::Mode a); MetaDataHandle(const Gaudi::DataHandle& handle, const std::string& descriptor, Gaudi::DataHandle::Mode a); @@ -89,25 +88,20 @@ MetaDataHandle::MetaDataHandle(const Gaudi::DataHandle& handle, const std::st //--------------------------------------------------------------------------- template std::optional MetaDataHandle::get_optional() const { - const auto& frame = m_podio_data_service->getMetaDataFrame(); - return frame.getParameter(fullDescriptor()); + if (m_podio_data_service) { + return m_podio_data_service->getMetaDataFrame().getParameter(fullDescriptor()); + } + return k4FWCore::getParameter(fullDescriptor()); } //--------------------------------------------------------------------------- template const T MetaDataHandle::get() const { - std::optional maybeVal; - // DataHandle based algorithms - if (m_podio_data_service) { - maybeVal = get_optional(); - if (!maybeVal.has_value()) { - throw GaudiException("MetaDataHandle empty handle access", - "MetaDataHandle " + fullDescriptor() + " not (yet?) available", StatusCode::FAILURE); - } - // Functional algorithms - } else { - maybeVal = k4FWCore::getParameter(fullDescriptor()); + auto optional_parameter = get_optional(); + if (!optional_parameter.has_value()) { + throw GaudiException("MetaDataHandle empty handle access", + "MetaDataHandle " + fullDescriptor() + " not (yet?) available", StatusCode::FAILURE); } - return maybeVal.value(); + return optional_parameter.value(); } //--------------------------------------------------------------------------- @@ -159,12 +153,8 @@ template void MetaDataHandle::checkPodioDataSvc() { if (cmd.find("genconf") != std::string::npos) return; - // The proper check would be the following: - // if (!m_podio_data_service && !Gaudi::svcLocator()->service("MetadataSvc")) { - // However, it seems there is always a service called "MetadataSvc" from Gaudi, - // so the check will always pass - if (!m_podio_data_service) { - std::cout << "Warning: MetaDataHandles require the PodioDataSvc (ignore if using IOSvc)" << std::endl; + if (!m_podio_data_service && !Gaudi::svcLocator()->service("MetadataSvc", false)) { + std::cout << "Warning: MetaDataHandles require the PodioDataSvc or for compatibility the MetadataSvc" << std::endl; } } diff --git a/test/k4FWCoreTest/src/components/k4FWCoreTest_cellID_reader.cpp b/test/k4FWCoreTest/src/components/k4FWCoreTest_cellID_reader.cpp index dcc37779..9d48733c 100644 --- a/test/k4FWCoreTest/src/components/k4FWCoreTest_cellID_reader.cpp +++ b/test/k4FWCoreTest/src/components/k4FWCoreTest_cellID_reader.cpp @@ -39,5 +39,17 @@ StatusCode k4FWCoreTest_cellID_reader::execute(const EventContext&) const { return StatusCode::FAILURE; } + auto optCellIDstr = m_cellIDHandle.get_optional(); + + if (!optCellIDstr.has_value()) { + error() << "ERROR: cellID is empty but was expected to hold a value" << endmsg; + return StatusCode::FAILURE; + } + + if (optCellIDstr.value() != cellIDstr) { + error() << "ERROR: metadata accessed with by optional and value differs" << endmsg; + return StatusCode::FAILURE; + } + return StatusCode::SUCCESS; }