Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type for breakpoints #23

Open
StephanCodes opened this issue Jan 18, 2022 · 4 comments
Open

Incorrect type for breakpoints #23

StephanCodes opened this issue Jan 18, 2022 · 4 comments

Comments

@StephanCodes
Copy link

StephanCodes commented Jan 18, 2022

Hi, I just started using this library and I'm very grateful for it. I noticed, however, that the type for the breakpoints appears to be incorrect. It is currently:

declare type Breakpoints = Record<number, object[]>;

But I believe it should be:

declare type Breakpoints = Record<number, object>;

I based this on the documentation of GlideJS itself: https://glidejs.com/docs/options/#breakpoints
Thanks again!

@arthurmmedeiros
Copy link

Were you able to make it work anyway?

It is not working to me, even if I provide the expected object.

@StephanCodes
Copy link
Author

Sorry, I eventually switched to another solution entirely. If I remember correctly, it did work after changing the type manually in the library. 🤔

@arthurmmedeiros
Copy link

Could you share how you managed to change the type manually in the library? Was it by overriding the type somehow?

@StephanCodes
Copy link
Author

Yeah, I did it in the ugliest way, by directly editing the file in my node_modules folder. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants