Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert client_signing_alg to symbol in key_or_secret. #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Convert client_signing_alg to symbol in key_or_secret. #58

wants to merge 1 commit into from

Conversation

iconoeugen
Copy link

Fixes #57

The options.client_signing_alg is provided as string by Gitlab when using omnibus for configuration, but is checked against symbol values.

For the cases where the client_signing_alg value is already provided as symbol, the change will have no side effect and the no code changes are required.

@iconoeugen
Convert client_signing_alg to symbol in key_or_secret.
fadb28a 
The options.client_signing_alg is provided as string by Gitlab when using omnibus for configuration, but is checked agains symbol values.
@coveralls
Copy link

coveralls commented Jul 11, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 99.472% when pulling fadb28a on iconoeugen:fix/issue_57_Verification_failed_if_client_signing_algorithm_is_string into 849b181 on jjbohn:master.

@jvkassi
Copy link

jvkassi commented Jan 22, 2021

Hello,

I got the same issue.
Is it possible to merge this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verification failed if client signing algorithm is string
3 participants
@iconoeugen @coveralls @jvkassi