sign: Hide tests behind feature #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienvincent
force-pushed
the
jv/hide-signing-tests
branch
2 times, most recently
from
9052413 to
42c543c
Compare
|
I'll update this later this evening, and add some docs to the contributing section 👍🏻 |
4 tasks
|
Sorry I didn't get a chance to address this today. Will tackle first thing in the morning. |
julienvincent
force-pushed
the
jv/hide-signing-tests
branch
from
42c543c to
bcf1116
Compare
|
I updated to conditionally run only if gpg is installed. @yuja Please can you take a look. |
julienvincent
force-pushed
the
jv/hide-signing-tests
branch
from
bcf1116 to
8501597
Compare
yuja
approved these changes
Feb 21, 2024
| } | ||
| test(); | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: alternatively, this could be a declarative macro. I don't know which is better overall. Both approaches have pros and cons.
macro_rules! gpg_guard {
() => {
if Command::new("gpg").arg("--version").status().is_err() {
eprintln!("Skipping because gpg is not installed on the system");
return;
}
};
}There was a problem hiding this comment.
Nice! Never used macros before. This looks nice to me will use this. Out of interest what would you consider the pros and cons in this context?
There was a problem hiding this comment.
closure: + obvious control flow, - nesting
macro: + less noisy, - hidden return statement
julienvincent
force-pushed
the
jv/hide-signing-tests
branch
from
8501597 to
a61fa6b
Compare
This adds a guard to the gpg signing tests which will skip the test if `gpg` is not installed on the system. This is done in order to avoid requiring all collaborators to have setup all the tools on their local machines that are required to test commit signing.
julienvincent
force-pushed
the
jv/hide-signing-tests
branch
from
a61fa6b to
e875b26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a cargo feature
signing-testswhich is used to disable the gpg and ssh signing tests unless set.This is done in order to avoid requiring all collaborators to have setup all the tools on their local machines that are required to test commit signing.
Not sure if this is the best way to address this.
Closes #3096