Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign-all = true does not sign commits created by jj split (but yes those created by jj new) #5106

Closed
jalil-salame opened this issue Dec 16, 2024 · 2 comments

Comments

@jalil-salame
Copy link

jalil-salame commented Dec 16, 2024

Description

I started using a Nitrokey 3A Mini device (required by work) to sign my commits. jj split does not sign the commits created.

Steps to Reproduce the Problem

  1. Setup a signing key.
  2. Do some changes.
  3. Run jj split and create two commits
  4. Observe the commits with git log --show-signature
  5. See that the commits created by jj split do not contain a signature.

Expected Behavior

Commits created by jj split should contain a signature

Actual Behavior

Commits created by jj split don't contain a signature

Specifications

  • Platform: linux
  • Version: jj 0.24.0
@jalil-salame
Copy link
Author

This might be related to #4561 as I noticed the commits were not using my work email, but my personal email.

@martinvonz
Copy link
Member

Yes, it's probably that. Feel free to reopen if it happens with commits authored by you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants