Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Style immutable nodes differently in log #3111

Closed
martinvonz opened this issue Feb 21, 2024 · 3 comments
Closed

FR: Style immutable nodes differently in log #3111

martinvonz opened this issue Feb 21, 2024 · 3 comments
Assignees
Labels
polish🪒🐃 Make existing features more convenient and more consistent

Comments

@martinvonz
Copy link
Member

Is your feature request related to a problem? Please describe.

jj log doesn't indicate which commits are immutable.

Describe the solution you'd like

We should indicate in some way which commits are immutable. Maybe we would use a symbol for it.

Describe alternatives you've considered

Mercurial (at least with the setup we use at Google) does it by coloring the commit id differently. We could do that in addition or instead.

@PhilipMetzger PhilipMetzger added the polish🪒🐃 Make existing features more convenient and more consistent label Feb 21, 2024
@necauqua
Copy link
Contributor

A slightly related thing that could be done here as well is configurable node symbols.

So there will be a generic config, something similar to node.default = '◉', node.immutable = '◆', maybe also node.working-copy = '@' although we had a bunch of discussions about how wc being @ is important because the revset symbol for wc is @

Slightly less related thing is having said config for any number of arbitrary revsets, not just immutable, I think that was also mentioned by someone.

I don't know if there were any feature requests for any of above

@zummenix
Copy link
Contributor

@martinvonz Perhaps, current issue could be closed, since there is #3260?

@martinvonz
Copy link
Member Author

@martinvonz Perhaps, current issue could be closed, since there is #3260?

Good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish🪒🐃 Make existing features more convenient and more consistent
Projects
None yet
Development

No branches or pull requests

4 participants