Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signaling.name is working with netVisual_aggregate but is not with netVisual_individual #264

Open
CroixJeremy2 opened this issue Nov 26, 2024 · 1 comment

Comments

@CroixJeremy2
Copy link

CroixJeremy2 commented Nov 26, 2024

Everything is in the title.
signaling.name = "my_personal_test" works with netVisual_aggregate(), but is not with netVisual_individual() somehow.


Current workaround that I found:

I went into the source codes of each function, and it appears that in netVisual_aggregate(), you call netVisual_circle(title.name = paste0(signaling.name, " signaling pathway network"), ...). Here, signaling.name is correctly used in this function.

Whereas, in netVisual_individual(), there is no signaling.name that is called somewhere... Instead, I found that you call netVisual_circle(title.name = signalName_i, ...). So I modified manually to netVisual_circle(title.name = paste(signalName_i, signaling.name), ...), and it seems to work now.

But there might be some conflicts elsewhere because I don't know all the details of your functions. For sure, you have to modify these lines of code for layout == "hierarchy", layout == "spatial", or layout == "chord" if you use them (personally, I stick with layout == "circle"). Hopefully, there are no other conflicts except those ones that I spotted, and it is a good correction. If so, could you include that update in the next release please? Otherwise, could you correct the conflicts and update the patched version in the next release please?

Thanks in advance, and thanks for this amazing package,
Best regards,

@CroixJeremy2 CroixJeremy2 changed the title signaling.name is working with netVisual_aggregate but not netVisual_individual signaling.name is working with netVisual_aggregate but is not with netVisual_individual Nov 26, 2024
@sqjin
Copy link
Member

sqjin commented Dec 12, 2024

@CroixJeremy2 Thanks for pointing it out. However, netVisual_individual() is used to visualize individual network of a particular L-R pairs. To simply the title name, then there is no need to include the signaling names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants