Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with zint 2.10.0 #160

Open
simonbcn opened this issue Jan 5, 2022 · 3 comments · May be fixed by #164
Open

Incompatibility with zint 2.10.0 #160

simonbcn opened this issue Jan 5, 2022 · 3 comments · May be fixed by #164

Comments

@simonbcn
Copy link

simonbcn commented Jan 5, 2022 

Arch Linux
glabels-qt (compiled from git source)
zint 2.10.0

At compile time:

CMake Error at cmake/Modules/FindLibZint.cmake:40 (string):
  string sub-command REGEX, mode REPLACE needs at least 6 arguments total to
  command.
Call Stack (most recent call first):
  CMakeLists.txt:129 (find_package)


CMake Error at cmake/Modules/FindLibZint.cmake:41 (string):
  string sub-command REGEX, mode REPLACE needs at least 6 arguments total to
  command.
Call Stack (most recent call first):
  CMakeLists.txt:129 (find_package)


CMake Error at cmake/Modules/FindLibZint.cmake:42 (string):
  string sub-command REGEX, mode REPLACE needs at least 6 arguments total to
  command.
Call Stack (most recent call first):
  CMakeLists.txt:129 (find_package)
@ckolumbus ckolumbus linked a pull request Feb 2, 2022 that will close this issue
Open
@KaiMartin
Copy link

I can confirm for current debian/testing (bookworm):

  • cmake fails at the configuration stage with the above errors
  • the patch in PR linked by ckolombus (Chris Drexler) fixed the problem
    → Thank you @ckolombus !

@grecky-goo
Copy link

in Cmake/Module/FindLIbZint.make, lines 40,41,42,43. Put quotes around the last item.
string (REGEX REPLACE "^.*VERSION_MAJOR ([0-9])" "\1" ZINT_MAJOR "${ZINT_MAJOR_H}")
string (REGEX REPLACE "^.*VERSION_MINOR ([0-9])" "\1" ZINT_MINOR "${ZINT_MINOR_H}")
string (REGEX REPLACE "^.*VERSION_RELEASE ([0-9])" "\1" ZINT_MICRO "${ZINT_MICRO_H}")
set (LIBZINT_VERSION_STRING "${ZINT_MAJOR}"."${ZINT_MINOR}"."${ZINT_MICRO}")

@simonbcn
Copy link
Author

I think this project is dead. The last commit was at February 2021.

gitlost added a commit to gitlost/glabels-qt that referenced this issue Dec 19, 2022
@gitlost
Add handling of new Zint API >= 2.7.0 for Zint backend and use latest
3b88071 
version (2.12.0) by default (issues jimevins#86 and jimevins#160, subsumes PR jimevins#164).

 - hack "FindLibZint.cmake" to use `zint -h` to get version;
   define `LIBZINT_VERSION`
 - add new API handling in `Zint` in LIBZINT_VERSION >= 20700 define,
   leaving 2.6.3 handling unchanged
 - add some new Zint barcodes and adjust style properties of various other
   Zint barcodes
 - enable check digit handling via Zint `option_2`
 - add horizontal alignment `halign` argument to `Barcode::addText()`,
   `QtRenderer::drawText()` and `DrawingPrimitiveText::DrawingPrimitiveText()`
   and use in `QtRenderer::drawText()` to cater for Zint EAN/UPC left/right
   text align of outside digits
 - guard against QT infinite loop bug in `QFontMetricsF` when point size
   < ~0.4 (MIN_POINT_SIZE)
@gitlost gitlost mentioned this issue Dec 19, 2022
Open
gitlost added a commit to gitlost/glabels-qt that referenced this issue Dec 18, 2023
@gitlost
Add handling of new Zint API >= 2.7.0 for Zint backend and use latest
0b01d69 
version (2.13.0) by default (issues jimevins#86 and jimevins#160, subsumes PR jimevins#164).

 - hack "FindLibZint.cmake" to use `zint -h` to get version;
   define `LIBZINT_VERSION`
 - add new API handling in `Zint` in LIBZINT_VERSION >= 20700 define,
   leaving 2.6.3 handling unchanged
 - add some new Zint barcodes and adjust style properties of various other
   Zint barcodes
 - enable check digit handling via Zint `option_2`
 - add horizontal alignment `halign` argument to `Barcode::addText()`,
   `QtRenderer::drawText()` and `DrawingPrimitiveText::DrawingPrimitiveText()`
   and use in `QtRenderer::drawText()` to cater for Zint EAN/UPC left/right
   text align of outside digits
 - guard against QT infinite loop bug in `QFontMetricsF` when point size
   < ~0.4 (MIN_POINT_SIZE)
@gitlost gitlost mentioned this issue Dec 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #160 REGEX in FindLibZint.cmake module ckolumbus/glabels-qt
3 participants
@simonbcn @KaiMartin @grecky-goo