Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accuracy on test set is {} based on the best model {} ????????? #20

Open
lemo2012 opened this issue Mar 6, 2018 · 1 comment
Open

Accuracy on test set is {} based on the best model {} ????????? #20

lemo2012 opened this issue Mar 6, 2018 · 1 comment

Comments

@lemo2012
Copy link

lemo2012 commented Mar 6, 2018

In you codes, the accuracy on test set is based on the latest model after all the train step finished, not based on the best model saved in checkpoint. Am I right?
@changukshin
Copy link

changukshin commented Mar 6, 2018 •
edited
Loading

No. Please see step 6.2 in train.py

The variable ‘path’ is the path of best model.
Not the latest model.

We assume the least validation loss model is the best model.

Please look forward about ‘validation based early stopping’.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lemo2012 @changukshin